Skip to content

Initialize $_SERVER['QUERY_STRING'] #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2020
Merged

Initialize $_SERVER['QUERY_STRING'] #16

merged 2 commits into from
Oct 29, 2020

Conversation

ebuzzz
Copy link
Contributor

@ebuzzz ebuzzz commented Oct 27, 2020

Initialize the $_SERVER['QUERY_STRING'] variable, to mimic normal behavior of most webservers.

@ebuzzz ebuzzz mentioned this pull request Oct 27, 2020
Closed
SamMousa
SamMousa reviewed Oct 27, 2020
View reviewed changes
Apache/nginx use an empty string when no query string is set, the PHP…
78a31c4 
… internal webserver ommits the property. For now, we cast possible null values to an empty string.
SamMousa
SamMousa approved these changes Oct 27, 2020
View reviewed changes
Copy link
Collaborator

@SamMousa SamMousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tests failing is not related to these changes

@samdark samdark merged commit 528e125 into Codeception:master Oct 29, 2020
@samdark
Copy link
Member

samdark commented Oct 29, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@SamMousa SamMousa SamMousa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebuzzz @samdark @SamMousa